search

collectiveaccess / providence

Cataloguing and data/media management application
GNU General Public License v3.0
295 stars 167 forks source link

Import bug introduced #1454

Closed Monica-Wood closed 1 year ago

Monica-Wood commented 1 year ago

Wanted to log this somewhere incase it was an obvious fix while I investigate further.

On Develop branch, most recent commit https://github.com/collectiveaccess/providence/commit/5762e821178576d93460dcb5239e38a1bd1a9aa2

before performing a pull, the most recent commit was around 17 May

Importing records is missing the username/userId and causing timeouts when using the recent changes widget.

Will update if I discover more.

collectiveaccess commented 1 year ago

What do you mean by missing username? Are log entries not getting associated user_ids?

Monica-Wood commented 1 year ago

Yes the logs, it's just blank where the username is. The Recent Changes shows who made the changes usually and this is also blank and causes the dashboard to either timeout or take a long time to load. This started happening with imports straight after a pull 2 days ago.

Monica-Wood commented 1 year ago

Screen Shot 2023-06-28 at 13 57 35 pm

Monica-Wood commented 1 year ago

Also on dev/php8 Narrowed it down to happening somewhere between the 8 June and 26 June

collectiveaccess commented 1 year ago

What user did it log when you ran imports before then? Imports on the command line aren't actually associated with a specific user.

Monica-Wood commented 1 year ago

These are imports from the UI, not the command line. (Unless running it as a background process would do this). Before this date, it recorded the user that ran the import.

example log of importing the same way with what I assume is the same mapping the day prior to the update (git pull)

Screen Shot 2023-06-28 at 14 32 02 pm

edit:(sorry, wrong screenshot)

collectiveaccess commented 1 year ago

Running current pull of dev/php8 UI imports do set user in the change log. You're running these in the background?

collectiveaccess commented 1 year ago

Please do a pull on develop and/or dev/php8 and try import again. It should associate the user with the log entries now.

Monica-Wood commented 1 year ago

I do know the ones dated 28 June were done as background, I can't tell you for sure about the other ones. So it's very possible that this is only happening to ones processed in background.

I guess the issue isn't just that there is no username attached to the logs, it's that having the recent changes widget on the dashboard is causing 504 timeouts when there is no username.

Monica-Wood commented 1 year ago

Hi Seth, I've confirmed the fix works on php8 branch. Will confirm the develop branch soon hopefully.