collectiveaccess / providence

Cataloguing and data/media management application
GNU General Public License v3.0
290 stars 166 forks source link

Install profile returns an error when there is none? #1489

Closed Monica-Wood closed 10 months ago

Monica-Wood commented 10 months ago

dev/php8

using the caUtils install.

Returning this error * Relationship type is not valid for because no relationship table was set; set in relationship type restriction setting valuation for UserInterface:acquisition_ui:Screen valuation:Placement valuation

however after install I look and this seems to be set the way intended.

This is the bundle in UI

<placement code="valuation">
    <bundle>ca_occurrences_related_list</bundle>
    <settings>
      <setting name="label" locale="en_AU">Valuations</setting>
      <setting name="add_label" locale="en_AU">add Valuation</setting>
      <setting name="restrict_to_relationship_types">valuation</setting>
      <setting name="restrict_to_types">valuation</setting>
    </settings>
</placement>

and the type block in ca_object_lots_x_occurrences relationshipTable

<type code="valuation" default="1" typeRestrictionRight="valuation" includeSubtypesRight="0">
  <labels>
    <label locale="en_AU">
      <typename>has valuation of</typename>
      <typename_reverse>is valuation of</typename_reverse>
    </label>
  </labels>
</type>
collectiveaccess commented 10 months ago

It's because they're related list bundles. It's complaining because we're expecting a table name, and those *_related_list bundles (which I wish we could kill) don't conform.

Monica-Wood commented 10 months ago

People do like the related lists. I thought I had more of them in there, but I think the others don't have a restrict_to_relationship_types.

I'm happy to ignore these errors, just trying to log anything I come across.

collectiveaccess commented 10 months ago

No it needs to be fixed.

collectiveaccess commented 10 months ago

I just pushed a fix for this (I hope). Can you please test and let me know?

Monica-Wood commented 10 months ago

Can confirm I installed today with out this error.