search

collectiveaccess / providence

Cataloguing and data/media management application
GNU General Public License v3.0
290 stars 166 forks source link

fsockopen a Weak Choice for IPv6 Environments #1571

Closed miqrogroove closed 2 months ago

miqrogroove commented 2 months ago

https://github.com/collectiveaccess/providence/blob/d62ff170859d67555baf171ddcb5d494c59d2593/app/lib/Controller/Request/RequestHTTP.php#L674

This implementation of the out-of-process indexing trigger leaves much to be desired. In dual stack hosts, the originating address becomes fairly unpredictable, which can be a problem for security configuration. In other words, I want to make an htaccess exception to allow these requests, but the client address changes randomly, and I don't want to allow the entire local subnet.

I suggest changing this to cURL or the HTTPMultiClient where there is at least enough flexibility to force IPv4 name resolution when needed.

collectiveaccess commented 2 months ago

It's completely different in the dev/php8 (to be v2.0) code and does not depend upon network connections as the 1.7 code does.