search

collectiveaccess / providence

Cataloguing and data/media management application
GNU General Public License v3.0
290 stars 166 forks source link

Move simplesaml include from /var/ to its location in /vendor #1573

Closed goetzk closed 1 month ago

goetzk commented 1 month ago

Hi Seth, This is a request for future: I suggest moving Shibboleth.php's simplesamlphp include from /var/ to the installed location under vendor.

kgoetz@L23001:~/source/collectiveaccess_providence$ rgrep var/simplesamlph
app/lib/Auth/Adapters/Shibboleth.php:require_once('/var/simplesamlphp/lib/_autoload.php');

Going by some other imports, that would be replaced with something like this:

require_once(__CA_BASE_DIR__.'/vendor/simplesamlphp/simplesamlphp/lib/_autoload.php');

This would enable installing directly from composer (eg composer require simplesamlphp/simplesamlphp ^2.0) and having CA find the location without any other filesystem fiddling.

I'm not sure if I'll get to this in the near term but thought I'd flag it up and will try to submit a change in future.

goetzk commented 1 month ago

I will submit these two PRs related to this issue, once they've been tested a bit more: https://github.com/medeopolis/providence/tree/dev-php8-composer-graphql-upgrade https://github.com/medeopolis/providence/tree/dev-php8-simplesaml-path