search

collectiveaccess / providence

Cataloguing and data/media management application
GNU General Public License v3.0
295 stars 167 forks source link

Improve error checking for Shib field map #1585

Closed goetzk closed 4 months ago

goetzk commented 4 months ago

Previously error checking was almost non existant and performed its task completely silently. This change brings missing elements in the map right to the fore by refusing to continue while uid and email are missing.

Rounding out the change is adding a stacktrace to "Could not create SimpleSAML auth object", we've been carrying this change locally for some time and its a great help in debugging.

collectiveaccess commented 4 months ago

I already have some pending changes that add detailed debugging logging. I'm also flipping the map, as we have users who reuse the same attribute for multiple values (Eg. email for both email and user_name), and the current implementation doesn't allow it. I'll merge your suggestions into as make sense and then you can give it a try.

collectiveaccess commented 4 months ago

Just pushed a dev/shibboleth-logging with changes. Can you give it a try? There's a new shibboleth_debug option in authentication.conf to trigger debug logging,

goetzk commented 4 months ago

I've only lightly tested but it appears to be behaving as expected - thanks. I will close this in deference to the (recently merged) fec3705daff1b5a4c04063e6ba1dc29625bf6a7a