search

collectiveidea / audited

Audited (formerly acts_as_audited) is an ORM extension that logs all changes to your Rails models.
MIT License
3.34k stars 645 forks source link

Replace RequestStore with `ActiveSupport::CurrentAttributes` #673

Closed the-spectator closed 7 months ago

the-spectator commented 1 year ago

Followup of https://github.com/collectiveidea/audited/pull/669

This PR is an attempt to use ActiveSupport::CurrentAttributes instead of the RequestStore gem.

flipsasser commented 1 year ago

👏 thank you @the-spectator!

akshay-birajdar commented 7 months ago

A friendly bump for the maintainers!

danielmorrison commented 7 months ago

I have merge regrets. I stupidly didn't wait for all the tests to pass.

danielmorrison commented 7 months ago

I reverted this. I'd love to merge a version of it again, but not with all the test failures we were seeing.

Unfortunately, chasing down those test failures isn't high on my priority list.