search

collectiveidea / awesome_nested_set

An awesome replacement for acts_as_nested_set and better_nested_set.
MIT License
2.39k stars 492 forks source link

Rails >= 5 should throw :abort #470

Closed maxime-carbonneau closed 2 years ago

maxime-carbonneau commented 2 years ago

With Rails >= 5 acts_as_nested_set :dependent => :restrict_with_error should abort the transaction with throw :abort not return false.

maxime-carbonneau commented 2 years ago

with Rails >= 5 acts_as_nested_set :dependent => :restrict_with_error should abort the transaction with throw :abort not return false

parndt commented 2 years ago

Thanks @maxime-carbonneau

I wanted to check this other piece of code too - I think maybe not because we're not adding any errors but need to change this too? https://github.com/collectiveidea/awesome_nested_set/pull/470/files#diff-a0f12b26cd209de4cb125097e13150ed6f2c02b8ff29c28cac6616924caa8635R25

maxime-carbonneau commented 2 years ago

@parndt let me know if I can help.