search

collectiveidea / delayed_job

Database based asynchronous priority queue system -- Extracted from Shopify
http://groups.google.com/group/delayed_job
MIT License
4.81k stars 955 forks source link

Unlock mime-type gem version to support Ruby 3 #1124

Closed yahonda closed 3 years ago

yahonda commented 3 years ago

This pull request addresses these syntax errors which has been fixed by https://github.com/mime-types/ruby-mime-types/pull/146

$ ruby -v
ruby 3.0.0dev (2020-10-24T13:53:53Z master 148961adcd) [x86_64-linux]
$ bundle exec rake spec

An error occurred while loading ./spec/delayed/command_spec.rb.
Failure/Error: require 'coveralls'

SyntaxError:
  /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/logger.rb:26: _1 is reserved for numbered parameter
  /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/logger.rb:26: _2 is reserved for numbered parameter
  /home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/logger.rb:26: _3 is reserved for numbered parameter
/home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/columnar.rb:16: warning: already initialized constant MIME::Types::Columnar::LOAD_MUTEX
/home/yahonda/.rbenv/versions/3.0.0-dev/lib/ruby/gems/3.0.0/gems/mime-types-2.6.2/lib/mime/types/columnar.rb:16: warning: previous definition of LOAD_MUTEX was here
albus522 commented 3 years ago

I think you have something odd on your system. That gem line is for jruby not MRI. It would not apply to MRI ruby 3.0. Nothing in delayed job's gemfile for MRI ruby pulls in mime-types.

yahonda commented 3 years ago

Thanks for the comment. It does not reproduce anymore. I might be doing something wrong.