Rails 7.0 support - Githubissues

collectiveidea / delayed_job

Database based asynchronous priority queue system -- Extracted from Shopify

http://groups.google.com/group/delayed_job

MIT License

4.81k stars 955 forks source link

Rails 7.0 support #1152

Closed willnet closed 2 years ago

willnet commented 2 years ago

Loose dependencies to allow Rails7 to be installed.
Improved the CI setup to run tests with the latest Ruby and Rails.
- jruby >= 9.3.0.0 fails, but I don't know how to fix it, so I leave it as it is.
- fix tests that failed in non jruby environments.

willnet commented 2 years ago

CI result is here

ghiculescu commented 2 years ago

This is preventing testing https://weblog.rubyonrails.org/2021/12/6/Rails-7-0-rc-1-released/

Could it please be merged?

nileshtrivedi commented 2 years ago

@willnet Your changes are still referencing 7.0.0.rc1. Rails 7.0 GA is released as of yesterday, so you might want to update this PR.

willnet commented 2 years ago

updated 😃

thestelz commented 2 years ago

Since rails 7.0.1 has been released, will this PR also support that version?

Sorry to be one of those people, but we are upgrading our app to rails 7.0.1, but can't due to no support in this gem yet.

If there is anything I can do to help, I am willing to put in a new PR for rails 7.0.1 support.

Thanks!

willnet commented 2 years ago

Added Rails 7.0.1 to ci settings 😃