search

collectiveidea / delayed_job_mongoid

Mongoid backend for delayed_job
MIT License
170 stars 120 forks source link

Feature/mongoid 7 compatibility #77

Closed Startouf closed 5 years ago

Startouf commented 5 years ago

Fixes #74

Startouf commented 5 years ago

Specs were green after the changes when running rspec locally on ruby 2.5.1

dblock commented 5 years ago

LGTM, update CHANGELOG and README? https://github.com/collectiveidea/delayed_job_mongoid/blob/master/CHANGELOG.md

jafuentest commented 5 years ago

@Startouf I updated the changelog and readme for you and sent a PR to your fork =)

dblock commented 5 years ago

@jafuentest You can redo a PR here if you want with @Startouf's changes

jafuentest commented 5 years ago

Done, #78

Startouf commented 5 years ago

Hey thanks, I've merged the PR on my side, so I guess we could close either this PR or #78 (sorry did not see the previous comment from months ago ^^")

Startouf commented 5 years ago

I have activated Travis on my repo, the PR is building there : https://github.com/Startouf/delayed_job_mongoid/pull/2

dblock commented 5 years ago

@Startouf Let's see if we can get hold of @sferik or @albus522 and get some more admin hands on this repo?

I am one of the rubygems owners so if anything we can fork, but I'd prefer not to.

dblock commented 5 years ago

Btw, this was discussed in https://github.com/collectiveidea/delayed_job_mongoid/issues/70, let me see if I can get someone's attention over email.

dblock commented 5 years ago

Closing in favor of https://github.com/collectiveidea/delayed_job_mongoid/pull/78

dblock commented 5 years ago

I've released 2.3.1 with Mongoid 7 support.