allow Rails 6 - Githubissues

collectiveidea / interactor-rails

Interactor Rails provides Rails support for the Interactor gem.

MIT License

437 stars 46 forks source link

allow Rails 6 #25

Closed fauxparse closed 5 years ago

fauxparse commented 5 years ago

Tests are passing in Rails 6, so the Gemspec should not restrict the Rails version to 5.2 or below.

zackchandler commented 5 years ago

Any reason not to merge this?

andreimoment commented 5 years ago

Could you please merge this?

zackchandler commented 5 years ago

Bump 🙏

morgoth commented 5 years ago

I guess this would require updating test matrix on travis as some of them are failing. Anyway, since Rails 6 is around the corner, can we have this moved forward?

memoxmrdl commented 5 years ago

Hi guys. Rails 6 is released, when could you merge this?

leifcr commented 5 years ago

As per this comment: https://github.com/collectiveidea/interactor-rails/issues/23#issuecomment-474560687

The following workaround works, but you loose the generators:

Use interactor gem directly

gem 'interactor', '~> 3.0'

In config/application.rb:

require 'interactor'

gaffneyc commented 5 years ago

Merging but I want to say that just bumping the version isn't enough to feel confident that everything is working. The README should be updated and a new rails60 gemfile should be added to the gemfiles directory (and added to Travis).

Going to take care of that in separate commits.

leifcr commented 5 years ago

@gaffneyc Thanks. I see you did that in a0fb12c0fd1b809078a64316cb10e9bf97c5f65e, 10a078ccfdb0c8f9b8f2b17ad761a5cf2c496e42, 8f9b9933fc8ed9f7012bc8bcab85b07a45638a8a, 769524d29c6887e6613b87fec6eec639284f8e4d and 609a052bc80a0f5211ecdc7d462cfeff0bdc4eaf