search

collectiveidea / interactor

Interactor provides a common interface for performing complex user interactions.
MIT License
3.36k stars 212 forks source link

fail! #37

Closed developerinlondon closed 10 years ago

developerinlondon commented 10 years ago

the current behaviour of the fail! method seems to allow a 'message' to be set and 'success?' to return false. but it carries on with the rest of the code.

i cant really see the benefit of this behaviour. doesnt it make more sense to have fail! actually abort the code after it fails?

also why the ! ?

what about just overriding fail instead?

brianhempel commented 10 years ago

I agree it is unintuitive. In version 3, fail! will halt execution.

brianhempel commented 10 years ago

V3 is on PR #28.