search

collectiveidea / json_spec

Easily handle JSON in RSpec and Cucumber
rubygems.org/gems/json_spec
MIT License
919 stars 114 forks source link

Add support for MiniTest #36

Open blowmage opened 11 years ago

blowmage commented 11 years ago

Allow json_spec to be used from minitest tests.

laserlemon commented 11 years ago

Awesome, thank you! :clap: I don't personally use MiniTest but I'm going to try to pull somebody in who does to review this before I pull.

phlipper commented 11 years ago

@blowmage this is a very nice addition, thank you! :+1: from me.

gaffneyc commented 11 years ago

@laserlemon: @jasonroelofs keeps talking about how we should use MiniTest more, he might be a good candidate

laserlemon commented 11 years ago

By all means @jasonroelofs, please chime in!

jasonroelofs commented 11 years ago

Well you guys know me, I love MiniTest and anything that helps people use MiniTest more is :+1: from me!

laserlemon commented 11 years ago

@jasonroelofs If you get a second, could you take a look at the commits/changes and let us know how it looks from another MiniTest user's perspective?

laserlemon commented 11 years ago

@blowmage I swear I don't distrust you as much as it sounds in this thread!

blowmage commented 11 years ago

@laserlemon lulz!

jasonroelofs commented 11 years ago

Nothing jumps out at me with this commit. As it is trying to keep the syntax of json_spec the same while allowing the use of MiniTest or Rspec under the hood I'd say it's done a good job of that.

rdamborsky commented 11 years ago

+1

johnsinco commented 11 years ago

Hi is this pulled? We'd like to make use of your gem in our minitest specs. Thx!!

benwoodward commented 9 years ago

+1