search

collectiveidea / json_spec

Easily handle JSON in RSpec and Cucumber
rubygems.org/gems/json_spec
MIT License
919 stars 114 forks source link

Bring back full RSpec runtime dependency #68

Closed skalee closed 10 years ago

skalee commented 10 years ago

Fixup for 8fdd8d2b3c725a2156690458ac7dbc36d5cdd94a.

Didn't commit by mistake. Every project which depends on JsonSpec will refuse to run specs without that. How pity that Travis couldn't detect this problem.

laserlemon commented 10 years ago

Good catch!

laserlemon commented 10 years ago

:vertical_traffic_light: :watch:

laserlemon commented 10 years ago

:vertical_traffic_light: :bomb:

skalee commented 10 years ago

I see. I'll have time to fix it in few hours.

skalee commented 10 years ago

Apparently Cucumber integration fully relies on RSpec. Until this changes, JsonSpec has to depend on both rspec-expectations and rspec-core. For this reason single dependency on rspec has been brought back.

skalee commented 10 years ago

@laserlemon Any comments on that? It actually reverts some of my merged-in changes thus fixes your master :laughing:

laserlemon commented 10 years ago

:+1: