search

collectiveidea / json_spec

Easily handle JSON in RSpec and Cucumber
rubygems.org/gems/json_spec
MIT License
919 stars 114 forks source link

Update for RSpec 3 beta 2 #71

Closed skalee closed 10 years ago

skalee commented 10 years ago

  1. Support new matcher interface.

    Do you prefer alias or alias_method? I'm using alias because it's RDoc-friendly and those matchers are not likely to be subclassed, but I can change to alias_method if you want.

  2. Explicitly enable both expectation syntaxes.

    Both fashions something.should be_like_this and expect(something).to be_like_this are used in tests so I enabled them. As in above, I can change it if you want to gradually force one or another and warnings seem helpful.

skalee commented 10 years ago

BTW how about setting RSpec to fail in case of deprecation warnings? If you don't need them to promote one syntax or another, they would be very helpful. Some pull requests (like #64) were created before beta 2 and they don't honor most recent deprecations.

johanneswuerbach commented 10 years ago

:+1:

skalee commented 10 years ago

Dependencies updated. Could anyone with an active real-life project confirm that it works well with stable RSpec 3? Tests indicate no problems.

dredozubov commented 10 years ago

@laserlemon @skalee looks ok, can we merge it?

mscottford commented 10 years ago

I can confirm that this is working.

ToMoCoop commented 10 years ago

Can someone merge this PR please?

laserlemon commented 10 years ago

Version 1.1.2 released.

dredozubov commented 10 years ago

:+1: