collectiveidea / json_spec

Easily handle JSON in RSpec and Cucumber

rubygems.org/gems/json_spec

MIT License

919 stars 114 forks source link

Suppress legacy warnings when using rspec 3 #73

Closed PascalTurbo closed 7 years ago

PascalTurbo commented 10 years ago

Hi There,

obviously json_spec isn't fully compatible with rspec 3 at the moment. So using it is really painfull because there are a lot of legacy warnings like this one:

JsonSpec::Matchers::HaveJsonSize implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.

Is there any chance to suppress these while waiting for a fully compatible version of json_spec?

skalee commented 10 years ago

71 fixes deprecations mentioned by you. I'm not aware of any other deprecations as of RSpec 3.0.0.beta2.

ms-ati commented 10 years ago

Current master HEAD (b48f7c) still gives me the warning

skalee commented 10 years ago

@ms-ati Correct. The pull request #71 has not been merged. I'm not sure why, perhaps @laserlemon is waiting for RSpec 3 final release. For now, why not switching to that pull request's ref (2cc577c0de2554919beb3f0117eec7da8685ac75)?

ms-ati commented 10 years ago

Ah! That makes sense. I'll do that then.

johanneswuerbach commented 10 years ago

Now rspec 3 is released. Ping @laserlemon :-)

ArturT commented 10 years ago