search

collectiveidea / json_spec

Easily handle JSON in RSpec and Cucumber
rubygems.org/gems/json_spec
MIT License
919 stars 114 forks source link

Raise error when checking a size of a json ruby value of nil #82

Closed eluns closed 9 years ago

eluns commented 9 years ago

Hi Steve, Please let me know what you think about the tests. Thanks, Beth

laserlemon commented 9 years ago

Travis is failing with your changes. I'm not available to dig into it but please take a look. I'll also leave some feedback on the code itself. Thank you!

eluns commented 9 years ago

Hi Steve, Thank you for the feedback. I have made the corrections. Do you think I should add more tests? Thanks again, Beth

laserlemon commented 9 years ago

Looks great, Beth. Would you please squash the commits where necessary. Because of the course correction, there are several commits which no longer apply and some commits are just tiny tweaks. Squashing the commits into one or two more feature-focused commits will help keep the Git history readable. Thank you!

eluns commented 9 years ago

Hi Steve, I was able to squash the commits into 2 commits. Anything else I could do? Thanks again for your time and help, Beth

laserlemon commented 9 years ago

No, looks great. Thank you. I'll merge shortly when I have time to ship a new release.

laserlemon commented 9 years ago

Version 1.1.4 released. Thank you!