search

collectiveidea / json_spec

Easily handle JSON in RSpec and Cucumber
rubygems.org/gems/json_spec
MIT License
919 stars 114 forks source link

CodeClimate gem, spec_helper note, and Travis hook #98

Closed olleolleolle closed 7 years ago

olleolleolle commented 7 years ago

This PR adds a CodeClimate spec_helper.rb start instruction, and the reporter gem to the CI gemfiles.

This is the output after a successful job:

$ bundle exec codeclimate-test-reporter
Cannot post results: environment variable CODECLIMATE_REPO_TOKEN must be set.
olleolleolle commented 7 years ago

@laserlemon Ohai, you were here, too.

laserlemon commented 7 years ago

I don't think the latest version of CodeClimate's test reporter needs the require: false.

laserlemon commented 7 years ago

Let's also add the gem to the root-level Gemfile.

laserlemon commented 7 years ago
olleolleolle commented 7 years ago

I found the note about the no-longer-required require: false at https://docs.codeclimate.com/docs/test-coverage-ruby

olleolleolle commented 7 years ago

@laserlemon Do you prefer a squashed single commit? (Or does it matter, when you can use the cool buttons of GitHub?)

laserlemon commented 7 years ago

No, that's fine! Unless there's a lot of unnecessary churn, corrections, etc.

laserlemon commented 7 years ago

@olleolleolle Any interest in investigating what it would take to make the suite pass for Ruby 2.4+? I'm seeing the ruby-head job is failing and I assume 2.4 will too but I don't think it's part of the build matrix currently. We should make sure we allow failure on all EOL Rubies while we're at it.

olleolleolle commented 7 years ago

Yeah, I run 2.4 and the first fail was Integer not Fixnum.