collectivenectar / therealrealoracle

Digital Oracle Deck App for iOS, done in the Godot Engine
1 stars 1 forks source link

Seeyourcards.tscn Carousel #6

Closed collectivenectar closed 2 years ago

collectivenectar commented 2 years ago

I'm pretty sure I need a new carousel for seeyourcards.tscn.

Build one.

It has different requirements, so just remember:

I might be able to design this using an hbox container inside of a scrollcontainer, but it would require learning a new way to get inertia.

collectivenectar commented 2 years ago

succeeded in building a finite carousel, but I've hit the same wall with some input issues. No answers yet in discord, will continue to pursue since it seems this is a bug I can't seem to navigate around - must confront it on some level even if I just end up patching something. touch up isn't being recognize in input handling, and carousel movement is sticking to mousemotion.

collectivenectar commented 2 years ago

touch up handling was fixed by moving logic from _gui_input(event) to _input(event) - for unknown reason click up was treated as if happening outside the container bounds, or outside of gui, something - don't know. It's working now though. Only issue left is that the first card is also appearing as the last card. Fix this and I can begin to test infinite vs finite, and then build an animation for selecting/sliding cards from the carousel.

collectivenectar commented 2 years ago

Other issue now evident. I was trying to emulate a user quickly swiping back and forth, and found that there are some issues with inertia. In some way, it seems the user can occasionally swipe right, and the card moves left. Testing through variables to see the corresponding component. I think this may be a good opportunity to learn more about debugging.

collectivenectar commented 2 years ago

Fixed all issues - silly problem related to mouse filter for reference_rects on card.tscn. Everything works proper now and I've even implemented carousel api for left/right button navigation. What's left now is making sure it works inside other scenes, and then after that I can begin to work on an animation for selecting cards.

collectivenectar commented 2 years ago

implementing the new finite carousel into the three scenes, currently working on the seeyourcards.tscn due to minimal complexity. Just need to write logic for updating the nav button visibility and I think it will be done.

collectivenectar commented 2 years ago

integrated into seeyourcards.tscn, no known bugs.

collectivenectar commented 2 years ago

Integrated it into journal/deckcarousel.tscn and removed previous carousel versions. Choose your cards.tscn is not working right now, but that's next.

collectivenectar commented 2 years ago

almost finished, just need to fix the saving function of show your cards.tscn and all three scenes will be integrated.

collectivenectar commented 2 years ago

fixed the saving button, it was an overlap issue with the layout progress UI container.

Considering this version of the carousel finished, as further features are not decided yet. Will open separate issue to manage those features.