search

college-resources / cores

GNU Affero General Public License v3.0
0 stars 0 forks source link

Rework theming to use more defaults #3

Open CrazyStevenz opened 4 years ago

CrazyStevenz commented 4 years ago

Right now, a lot of dark theme color settings are set inside the components themselves, ovewriting defaults. This happens due to two mistakes made during the original theming process:

  1. The navbar uses the primary.dark color instead of a dedicated accent color

  2. The primary colors for dark theme are the accent colors instead of white

CrazyStevenz commented 4 years ago

Material UI v5 is reworking theming so we're going to wait for them to complete it before making any changes.