search

collin80 / GEVCU

Generalized Electric Vehicle Control Unit
114 stars 56 forks source link

gevcu edits for throttles #26

Closed cgalpin closed 11 years ago

cgalpin commented 11 years ago

Collin, I think you should apply these and set

define CFG_THROTTLE2_PIN 1

in config.h

After that, I think it should detect T2 is not connected and not report anything for it. You can also set TPOT=1 before running the detection and this should have the same effect

jrickard commented 11 years ago

I already did set TPOT=1. It appeared to take.

Jack Rickard

On Fri, Sep 6, 2013 at 9:56 AM, cgalpin notifications@github.com wrote:

Collin, I think you should apply these and set

define CFG_THROTTLE2_PIN 1

in config.h

After that, I think it should detect T2 is not connected and not report anything for it. You can also set TPOT=1 before running the detection and

this should have the same effect

You can merge this Pull Request by running

git pull https://github.com/cgalpin/GEVCU master

Or view, comment on, or merge it at:

https://github.com/collin80/GEVCU/pull/26 Commit Summary

  • using collins for merge fix
  • restore GEVCU edits and add warming for unknown commands

File Changes

  • M DeviceManager.cpphttps://github.com/collin80/GEVCU/pull/26/files#diff-0(10)
  • M GEVCU.inohttps://github.com/collin80/GEVCU/pull/26/files#diff-1(19)
  • M SerialConsole.cpphttps://github.com/collin80/GEVCU/pull/26/files#diff-2(3)

Patch Links:

http://www.EVTV.me http://EVTV.me

Electric Vehicle Television - KickinGas - One Car at a Time.

cgalpin commented 11 years ago

Great. Would you mind sharing the serial log output of your session? I'd like to get an idea of what things look like with all the hardeware.

Thanks, charles

On Sep 6, 2013, at 11:05 AM, Jack Rickard wrote:

I already did set TPOT=1. It appeared to take.

Jack Rickard

On Fri, Sep 6, 2013 at 9:56 AM, cgalpin notifications@github.com wrote:

Collin, I think you should apply these and set

define CFG_THROTTLE2_PIN 1

in config.h

After that, I think it should detect T2 is not connected and not report anything for it. You can also set TPOT=1 before running the detection and

this should have the same effect

You can merge this Pull Request by running

git pull https://github.com/cgalpin/GEVCU master

Or view, comment on, or merge it at:

https://github.com/collin80/GEVCU/pull/26 Commit Summary

  • using collins for merge fix
  • restore GEVCU edits and add warming for unknown commands

File Changes

  • M DeviceManager.cpphttps://github.com/collin80/GEVCU/pull/26/files#diff-0(10)
  • M GEVCU.inohttps://github.com/collin80/GEVCU/pull/26/files#diff-1(19)
  • M SerialConsole.cpphttps://github.com/collin80/GEVCU/pull/26/files#diff-2(3)

Patch Links:

http://www.EVTV.me http://EVTV.me

Electric Vehicle Television - KickinGas - One Car at a Time. — Reply to this email directly or view it on GitHub.