search

collin80 / GEVCU

Generalized Electric Vehicle Control Unit
114 stars 56 forks source link

Added visualization of throttle settings #44

Closed cgalpin closed 11 years ago

cgalpin commented 11 years ago

Added visualization of throttle settings. Tested by Michael so ready to be merged.

jrickard commented 11 years ago

I'm not much of one for rules. And I understand that you guys are accomplishing much with little to work from regarding a test facility. My own spotty reports being worked in between a lot of other stuff and so rarely timely.

But could we all agree not to submit code unless we at least SEE IT COMPILE once in a row and see what it looks like on screen at least?

For what its worth Charles, I think Windoze 7, I downloaded the packing program and got exactly teh same error message you did. Obviously a great piece of code on a finely tuned Operating System - gag - retch.

On Tue, Oct 22, 2013 at 7:44 PM, Charles Galpin notifications@github.comwrote:

Added visualization of throttle settings. Note that I am unable to test

this because I can't pack the website right now.

You can merge this Pull Request by running

git pull https://github.com/cgalpin/GEVCU ArduinoDue

Or view, comment on, or merge it at:

https://github.com/collin80/GEVCU/pull/44 Commit Summary

  • Added visualization of throttle settings
  • fixed typo

File Changes

  • M website/src/control.jshttps://github.com/collin80/GEVCU/pull/44/files#diff-0(2)
  • M website/src/index.htmhttps://github.com/collin80/GEVCU/pull/44/files#diff-1(18)
  • A website/src/throttleSettingsCanvas.jshttps://github.com/collin80/GEVCU/pull/44/files#diff-2(309)

Patch Links:

http://www.EVTV.me http://EVTV.me

Electric Vehicle Television - KickinGas - One Car at a Time.

cgalpin commented 11 years ago

I said it in my last email but will add it here too. What I checked in was safe because until you actually pack it into the website.img no-one other than I think Michael and possibly Collin would even be affected, and until I can get it running I felt it was best to get it in. It's trivial to disable if not.

But I agree in general. The code should at least compile before checking it in :)

charles

On Oct 23, 2013, at 7:10 AM, Jack Rickard notifications@github.com wrote:

I'm not much of one for rules. And I understand that you guys are accomplishing much with little to work from regarding a test facility. My own spotty reports being worked in between a lot of other stuff and so rarely timely.

But could we all agree not to submit code unless we at least SEE IT COMPILE once in a row and see what it looks like on screen at least?

For what its worth Charles, I think Windoze 7, I downloaded the packing program and got exactly teh same error message you did. Obviously a great piece of code on a finely tuned Operating System - gag - retch.

On Tue, Oct 22, 2013 at 7:44 PM, Charles Galpin notifications@github.comwrote:

Added visualization of throttle settings. Note that I am unable to test

this because I can't pack the website right now.

You can merge this Pull Request by running

git pull https://github.com/cgalpin/GEVCU ArduinoDue

Or view, comment on, or merge it at:

https://github.com/collin80/GEVCU/pull/44 Commit Summary

  • Added visualization of throttle settings
  • fixed typo

File Changes

  • M website/src/control.jshttps://github.com/collin80/GEVCU/pull/44/files#diff-0(2)
  • M website/src/index.htmhttps://github.com/collin80/GEVCU/pull/44/files#diff-1(18)
  • A website/src/throttleSettingsCanvas.jshttps://github.com/collin80/GEVCU/pull/44/files#diff-2(309)

Patch Links:

http://www.EVTV.me http://EVTV.me

Electric Vehicle Television - KickinGas - One Car at a Time. — Reply to this email directly or view it on GitHub.

neuweiler commented 11 years ago

yes, I entirely agree and apologize for my latest hick-up with the code not compiling.. I usually always compile everything before checking in. Might have been an accidental "delete" after compiling.

On 23.10.2013 13:38, Charles Galpin wrote:

I said it in my last email but will add it here too. What I checked in was safe because until you actually pack it into the website.img no-one other than I think Michael and possibly Collin would even be affected, and until I can get it running I felt it was best to get it in. It's trivial to disable if not.

But I agree in general. The code should at least compile before checking it in :)

charles

On Oct 23, 2013, at 7:10 AM, Jack Rickard notifications@github.com wrote:

I'm not much of one for rules. And I understand that you guys are accomplishing much with little to work from regarding a test facility. My own spotty reports being worked in between a lot of other stuff and so rarely timely.

But could we all agree not to submit code unless we at least SEE IT COMPILE once in a row and see what it looks like on screen at least?

For what its worth Charles, I think Windoze 7, I downloaded the packing program and got exactly teh same error message you did. Obviously a great piece of code on a finely tuned Operating System - gag - retch.

On Tue, Oct 22, 2013 at 7:44 PM, Charles Galpin notifications@github.comwrote:

Added visualization of throttle settings. Note that I am unable to test

this because I can't pack the website right now.

You can merge this Pull Request by running

git pull https://github.com/cgalpin/GEVCU ArduinoDue

Or view, comment on, or merge it at:

https://github.com/collin80/GEVCU/pull/44 Commit Summary

  • Added visualization of throttle settings
  • fixed typo

File Changes

  • M website/src/control.jshttps://github.com/collin80/GEVCU/pull/44/files#diff-0(2)
  • M website/src/index.htmhttps://github.com/collin80/GEVCU/pull/44/files#diff-1(18)
  • A website/src/throttleSettingsCanvas.jshttps://github.com/collin80/GEVCU/pull/44/files#diff-2(309)

Patch Links:

http://www.EVTV.me http://EVTV.me

Electric Vehicle Television - KickinGas - One Car at a Time. — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/collin80/GEVCU/pull/44#issuecomment-26897806.