search

collin80 / GEVCU

Generalized Electric Vehicle Control Unit
114 stars 56 forks source link

Refactoring, optimizations #95

Closed neuweiler closed 8 years ago

neuweiler commented 9 years ago

add description of eeprom layout move calls from device subclass::setup() to Device. correctly set number of TX and RX mailboxes (according to configured value) fix problem in state handling when going to Status::error

cgalpin commented 8 years ago

Nice work Michael. I noticed a small typo in MotorController.cpp

Logger::info(getId(), "Slew rate: %i, Slew rate: %i", config->slewRate, config->slewType);

should be

Logger::info(getId(), "Slew rate: %i, Slew type: %i", config->slewRate, config->slewType);

I don't have a working setup or time to make this change, but I was thinking it would be good to report the software revision of the code on the web page from CFG_BUILD_NUM and CFG_VERSION

neuweiler commented 8 years ago

Thanks.. but while testing the linear slew rate, I don't see a reason anymore to figure out the maths for an exponential slew type --> maybe drop the slew type again. It should be easy to add the build number / version to the page - next to the title. Right now, the version is hard coded in the html (e.g. 5.3).

On 26/03/16 22:56, Charles Galpin wrote:

Nice work Michael. I noticed a small typo in MotorController.cpp

|Logger::info(getId(), "Slew rate: %i, Slew rate: %i", config->slewRate, config->slewType);|

should be

|Logger::info(getId(), "Slew rate: %i, Slew type: %i", config->slewRate, config->slewType);|

I don't have a working setup or time to make this change, but I was thinking it would be good to report the software revision of the code on the web page from CFG_BUILD_NUM and CFG_VERSION

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/collin80/GEVCU/pull/95#issuecomment-201936949