collin80 / GVRET

Generalized Vehicle Reverse Engineering Tool - firmware for Arduino Due based boards
99 stars 32 forks source link

Bug in time sync #3

Closed yoh-there closed 9 years ago

yoh-there commented 9 years ago

Going through the source code to document the interface, I think there is a bug in the TIME_SYNC block (line 619, build 322). I know it doesn't do a thing now, but it also doesn't reset the state to IDLE. Doesn't that lock it up?

collin80 commented 9 years ago

You're correct. That feature was never implemented and calling it would have locked up the sketch. Good catch! This oversight has been corrected as of firmware version 323.