search

collin80 / M2RET

GVRET fork to Macchina M2 board
MIT License
70 stars 21 forks source link

due_can requires can_common #7

Closed rmcolbert closed 6 years ago

rmcolbert commented 6 years ago

Readme needs to include a reference to the can_common library for people building M2RET from scratch.

Damian-R-Smith commented 6 years ago

can_common is a dependency of due_can, not M2RET directly and is already mentioned in the due_can README so surely there is no reason to include it in the M2RET README?

(As a sidenote; If you feel this is really needed then why not add it yourself and make a pull request to have it included?)

rmcolbert commented 6 years ago

Yes, Collin's due_can added a dependency and it is listed in its readme (but not above the fold on the home page so you need to dig into the readme). Adding it to the M2RET readme makes sense since someone compiling it for the first time will see it ... and someone updating their source will review it but may not review the other libraries.

From: Damian Smith notifications@github.com Sent: Saturday, January 13, 2018 7:35:32 PM To: collin80/M2RET Cc: Robert Colbert; Author Subject: Re: [collin80/M2RET] due_can requires can_common (#7)

can_common is a dependency of due_can, not M2RET directly and is already mentioned in the due_can README so surely there is no reason to include it in the M2RET README?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/collin80/M2RET/issues/7#issuecomment-357481686, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALUxnNwmUOyKPm0kWn1OOqFf7XbH9luFks5tKVnkgaJpZM4RUi8y.

Damian-R-Smith commented 6 years ago

I see what you mean, yeah maybe it can do no harm to include this in the M2RET readme

collin80 commented 6 years ago

Sorry I didn't get to this until now. I've updated the readme to point mcp2515 to my version and have added the can_common dependency right in this readme so that people are aware you need it. Hopefully this helps every in the future. Thanks for all of your comments.