search

collin80 / M2RET

GVRET fork to Macchina M2 board
MIT License
70 stars 21 forks source link

2017-11-11 Commit breaks compat w/ Macchina mcp2515 library #8

Closed rmcolbert closed 6 years ago

rmcolbert commented 6 years ago

Read Me points to the Macchina repo for mcp2515 but code needs updates added to Collin's fork. Either the read me should point to Collin's fork or a pull request to the Macchina repo should be created.

Damian-R-Smith commented 6 years ago

Can you provide the commit id for which one you are talking about? (I see no commits for 11th November 2017 in the history). Can you elaborate on the issue more so myself or others can look at it, or if you understand the issue why not just create the pull request yourself?

rmcolbert commented 6 years ago

Commit #7e26a9f

I don't know why it broke, I rolled back commits until I found code that would compile.

From: Damian Smith notifications@github.com Sent: Saturday, January 13, 2018 7:46:17 PM To: collin80/M2RET Cc: Robert Colbert; Author Subject: Re: [collin80/M2RET] 2017-11-11 Commit breaks compat w/ Macchina mcp2515 library (#8)

Can you provide the commit id for which one you are talking about? (I see no commits for 11th November 2017 in the history). Can you elaborate on the issue more so myself or others can look at it, or if you understand the issue why not just create the pull request yourself?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/collin80/M2RET/issues/8#issuecomment-357482146, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALUxnMMgpMunny9Eh_gC_n-zHqbv4rrhks5tKVxpgaJpZM4RUm2i.

Damian-R-Smith commented 6 years ago

Thanks. I think my local is behind by a few commits so I didn't see a compile issue. I'll try to look into this and see what happened.