search

collin80 / SavvyCAN

QT based cross platform canbus tool
MIT License
1k stars 278 forks source link

Warn about unsaved changed in dbc database #215

Open FabianInostroza opened 4 years ago

FabianInostroza commented 4 years ago

When closing SavvyCAN with some modified dbc it doesn't warn about unsaved changes, possibly leading to data loss (I've been bitten by this)

collin80 commented 4 years ago

You're right, it doesn't warn you about unsaved work but it really should. So, I'll leave this open and try to remember to add this in the near future.

exekutive commented 4 years ago

I would be OK with SavvyCAN saving to dbc file in real time. It's a bit annoying to have to confirm overwrite every time I save my changes. (which I do often since SavvyCAN does crash once in a while).

collin80 commented 4 years ago

Yes, sometimes it crashes. I would like to fix up all the crashes but still it would be nice to be able to save your work before the whole thing dies if it ever happens. A realtime update option wouldn't necessarily be a bad idea.

collin80 commented 4 years ago

I did add a warning about unsaved changed in this commit: 44aa622cd9973564e6fb382f23f98d2c40a18b4d

Still no realtime saving option so I'll leave this open.