collin80 / SavvyCAN

QT based cross platform canbus tool
MIT License
1.04k stars 288 forks source link

Issues with disconnecting GVRET style device #88

Closed collin80 closed 5 years ago

collin80 commented 7 years ago

If you disconnect a GVRET style device it can lock up the underlying hardware in the device. This is likely an issue with the Arduino USB serial stack as it can then overflow if nothing is connected. In the past the code tried to figure out if anyone was connected and not write if no one was listening. This can be problematic to figure out. This isn't really a SavvyCAN issue but it crosses a variety of devices. It might not happen on Teensy devices as the USB serial stack is different. Check for that.

Also, the connection window doesn't seem to reliably detect that the GVRET device is gone and says that it is still connected. It would be good to detect the disconnection and show it properly.

collin80 commented 6 years ago

In WIP it can now show that a GVRET device was disconnected when it disappears. But, sometimes trying to reconnect the device without closing the program is still problematic. Continue fixing this.

collin80 commented 5 years ago

Things seem to work pretty well as of 8ee9805a786ea2e4065e740f2cf8e4007f4a5d01