search

collin80 / SavvyCAN

QT based cross platform canbus tool
MIT License
1.04k stars 288 forks source link

Support ISO-TP extended addressing #95

Closed Semant1ka closed 7 years ago

Semant1ka commented 7 years ago

Hi, I've seen a neat option in ISO-TP handler which enables extended addressing parsing, it seems to work fine, maybe it should be included in iso-tp window? Also, the iso-tp window is not closing after main window closes. So...I can add those things to iso-tp window and create a pull request. May I ?

collin80 commented 7 years ago

Yes, by all means, if you'd like to fix those issues I'd be happy to merge the changes in. Thanks.

On Sat, Oct 14, 2017 at 3:53 PM, Polina Slavskaya notifications@github.com wrote:

Hi, I've seen a neat option in ISO-TP handler which enables extended addressing parsing, it seems to work fine, maybe it should be included in iso-tp window? Also, the iso-tp window is not closing after main window closes. So...I can add those things to iso-tp window and create a pull request. May I ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/collin80/SavvyCAN/issues/95, or mute the thread https://github.com/notifications/unsubscribe-auth/ACC7ZboXqQgrS38LJBM4cp4zsz1-ALFXks5ssREngaJpZM4P5gcf .