search

collinb9 / understatAPI

An API for scraping data from understat.com
MIT License
10 stars 2 forks source link

Typo in Readme #9

Closed hedonistrh closed 2 years ago

hedonistrh commented 2 years ago

In the readme, it says following for git related cloning

git clone git@github.com:collinb9/understatAPI understatAPI

I am using https one but for git one, i think it should be following for git one.

git clone git@github.com:collinb9/understatAPI.git
hedonistrh commented 2 years ago

In addition to that, I also think there is no setup.py in the current version of the repo so following won't work. 🤔 

python setup.py install
collinb9 commented 2 years ago

Yeah good catch, thanks. I recently switched from setup.py to pyproject.toml & setup.cfg, forgot to fix the readme

collinb9 commented 2 years ago

I think the line about cloning the repo is fine, but I've updated the installation instructions. Closing this issue now