collinsmith / riiablo

Diablo II remade using Java and LibGDX
http://riiablo.com
Apache License 2.0
869 stars 99 forks source link

BitInput#readSlice initial state of bitsRead #128

Open collinsmith opened 3 years ago

collinsmith commented 3 years ago

6be4e48a changed a problematic test case to pass stemming from a change made to BitInput#readSlice where the slice starts with an initial state of slice.bitsRead = parent.bitsRead. Should this be the expected value and not 0 bits read?

This method was added when changes were made to the DCC codec reading different compressed streams as slices so that an assertion can be made on the number of bits were read from the stream. Need to look into this and provide documentation for this.