search

collinsmith / riiablo

Diablo II remade using Java and LibGDX
http://riiablo.com
Apache License 2.0
869 stars 99 forks source link

Attributes.java line 234 parameter type should change from short to int. #144

Open zxh9813 opened 2 years ago

zxh9813 commented 2 years ago

I am able to run after changing below parameter from short to int 图片

collinsmith commented 2 years ago

iirc, this is expected behavior. stat should be a constant and within a known range unsigned 0..0x1f, all places this function is used should be read and cast to short anyways. Was there a specific problem in another area?

zxh9813 commented 2 years ago

After I changing Attributes.java and StatListRef.java. I was able to start it.

collinsmith commented 2 years ago

I can start without that change. What error were you getting?