collinsmith / riiablo

Diablo II remade using Java and LibGDX
http://riiablo.com
Apache License 2.0
884 stars 101 forks source link

fix modules that relied on gdx.diablo #31

Open collinsmith opened 5 years ago

collinsmith commented 5 years ago

fc5786a broke a lot of existing older modules that should be ported over where possible. Some of these were using deprecated features that the riiablo refactor removed (really, really old code that was since long redeveloped).

collinsmith commented 5 years ago

Whew, that was a nightmare. I guess let me know here if there are any problems. I may need to rework DesktopLauncher due to the riiablo refactor changes. I added two command-line arguments -i 853 -o 480 to indicate width/height of the window. These will be removed in production and are used so that I can test a variety of scaling/aspect ratios. I noticed a couple problems trying to run without them and they shouldn't be necessary to have either. 853x480 is the target native resolution BTW. I'll fix this and come up with a better solution so that I can test my hail of resolutions.

FYI, I test 640x480, 853x480, 640x360, 720x360, 840x360, 1280x720. 360p resolutions are mobile with 720x360 being 18:9 that newer phones use. I just want to add to, not all of the menus have had their UI reworked with the newer scaling (multiplayer), but those that have and the in-game in general looks pretty fantastic and works significantly better on mobile.

collinsmith commented 5 years ago

e9910c7bda396faa450dd03787b04bce78276d38 fixed some of the more serious MPQ Viewer crashes since the riiablo rebase. I've decided to move in a bit of a different direction with it and am replacing single-MPQ view support with multi-MPQ view (i.e., instead of only viewing files from a single MPQ, it will now show all files from all MPQs in a specified home directory). This is more useful to this project and viewing a single MPQ is now outside the scope of this tool. If this feature is requested at a later time, support may be added.

collinsmith commented 5 years ago

tester module has begun end-of-life and some of the more useful tools have been ported over to tools module. I am going to deprecate the module soon but leave the code as a lot of it will be useful when tests are written for core modules (a lot of the classes within tester are developmental tests for codecs/classes within core, so they are a good jumping point even if a lot of the code is archaic).