collinss / Cinnamon-Soundbox

Desklet to manage Sound settings and view and control currently playing media
5 stars 3 forks source link

Cinamon 2.3 or higer... #16

Closed ghost closed 10 years ago

ghost commented 10 years ago

I see that you have some things about DBus and Cinnamon 2.3.

This code show how i merge old GLib Dbus(Cinnamon 2.2) with new Gio Dbus(Cinnamon 2.3). This result in desklet working on old and new Cinnamon Version, without problems. https://github.com/lestcape/Drives-Manager/commit/ed83b8618e27c0d4f6331992d1201a719e37f390

collinss commented 10 years ago

Thanks for the info, but I don't really have the time right now to make the extensive changes that this would require (this is a very large desklet, and dbus is used all over the place). As an added complication, I am almost done with a major rework of the underlying code to make it easier to port it to an application or extension (I plan to do both in the near future), so it would not be a trivial matter to put the old DBus code back in there.

In addition, I'm not planning to post another update until 2.4, at which point I don't expect there to be much demand for a version that's compatible with 2.2, as those who are still using it at that point probably already have my desklet installed if they want to use it. For anyone who does want it, I can always make an older version available somewhere and post a link to it.

In short, I don't think it's worth the time and effort to make the latest version work for a version of Cinnamon that wont even really be supported by the time this is released.

ghost commented 10 years ago

Yep, i understand your point of view... I don't share it, but i understand... I like to have your implementation of rise a desklet in cinnamon code... I come with here to steal your implementation to raised desklet, to be used in drives manager and i see your comment in spices... This is why i open the issue...

ghost commented 10 years ago

And also thanks... You fixed an old problem in muffin... this is really important to me...