search

collinss / Cinnamon-Sticky-Notes

A sticky note applet for the Cinnamon DE
6 stars 2 forks source link

Replaced deprecated Applet.MenuItem with PopupMenu.PopupMenuItem #6

Closed yrtimiD closed 9 years ago

yrtimiD commented 9 years ago

Accordingly to (imports.ui.applet documentation)[http://developer.linuxmint.com/reference/2.6/cinnamon-js/cinnamon-js-ui-applet-section.html] Applet.MenuItem is deprecated.

I replaced note context menu creating with menu.Add* methods which seems to work. This should fix this issue: collinss/Cinnamon-Sticky-Notes#5

collinss commented 9 years ago

Applet.MenuItem wasn't deprecated until Cinnamon 2.6, which was just released, but it still works. I'm not entirely sure what is causing the problem, but I noticed from your other post that you are using Cinnamon 2.2, so my guess is that https://github.com/yrtimiD/Cinnamon-Sticky-Notes/commit/17f7c896a624284740c2cca701766b54875b37cf is causing it. Cinnamon 2.4 and later has the About Dialog methods included by default, and my handling was redundant, so I removed it.

You should be able to comment out just the lines related to the about dialog (I think there is only one left anyway) to use the latest version, or you can go back to version 1.1 by downloading https://github.com/collinss/Cinnamon-Sticky-Notes/tree/2333227b57a13d1bfab9d2bf715a2ff5d4e5ebee.

yrtimiD commented 9 years ago

You are right, the line which tried to add About menu prevented all following menu items to be added.