collinss / cinnamon-places-center

Cinnamon Applet to give quick access to comon filesystem locations.
6 stars 1 forks source link

Symbolic panel icon #1

Closed ghost closed 10 years ago

ghost commented 10 years ago

Would you consider adding a symbolic panel icon?Looks pretty out fo place on the panel. :/

collinss commented 10 years ago

Done.

New version has an option for that in settings.

ghost commented 10 years ago

Well that was pretty bloody fast XD Thanks!

collinss commented 10 years ago

No problem. It didn't take all that much effort as I had already added that feature to another applet. :)

ghost commented 10 years ago

The symbolic icon is gone again? Also left/right padding in the popup is too small now

collinss commented 10 years ago

Try adding -symbolic to your icon name. I didn't remove the option, only changed it to behave more like the menu applet.

As for the padding, I couldn't make it look good on all themes, so I decided to make it more themeable instead. I thought about adding the padding back in through css, but as there are some themes that are designed to look better with no padding at all on the sides, I decided against it. I looks like I could have removed the padding from between sections though. If you want to theme it you can look at stylesheet.css in the applet folder for a list of available tags. Once I'm done, those tags should work for Office Center and Graphics Center as well.

ghost commented 10 years ago

I hadn´t noticed that you added a stylesheet!I updated my main themes.

collinss commented 10 years ago

@zagortenay333 Just FYI: I just added a couple more available tags - xCenter-scrollBox and xCenter-menuItemLabel. The first one allows you to style just the scrollable area, while the second lets you set a max-width for the menu item label. I don't know if you will find them useful or not, but they're there now if you want to use them.

ghost commented 10 years ago

I made use of the fact that the .xCenter-pane selector also works for the Recent section to update the Zukitwo-Dark theme.Check it out!

collinss commented 10 years ago

Not bad! I'm glad you were able to do something with this.

Also, I see that you were able to make use of the about dialog tags. I plan to add the same dialog to all of my spices, and at some point I'm planning to submit a pull request to Cinnamon to add it for all applets and desklets. It will be nice to already have some themes that support it.

ghost commented 10 years ago

Indeed, those about dialogs look very neat!

One thing I noticed is that the link in the about dialog doesn´t support an underline.I tried text-decoration: underline, but it doesn´t seem to work here.

Oh and one more thing, do you know whether it is possible to override certain general css properties for popups in the case of individual apples?What I would love to have is the ability to keep a vertical padding for all popups but override it for some. Here is an example: secondary_007

And this is what I would love to achieve: secondary_006

Usually I accomplish this using descendant combinators. For example, I used one for this applet to override the hover effect from a light rectangle to a black rectangle .xCenter-mainBox .popup-menu-item:active {}, but here I have no clue how to do it. I also mentioned it in this issue https://github.com/mockturtl/cinnamon-weather/issues/65 Any ideas?

collinss commented 10 years ago

There are a number of possible solutions that I can think of, but they all involve changing the code in cinnamon, or the applet itself. I don't know of any way to do it using only css. Unfortunately css doesn't have a "parent" or "contains" selector. If you want, I can add a name to the popupmenu, so it would at least work on mine.

ghost commented 10 years ago

Would be awesome.And if your solution works, could you propose to the guy who makes the weather applet to do the same?

collinss commented 10 years ago

With the latest versions of my applets, .xCenter-menu should allow you to override any element in the menu.

ghost commented 10 years ago

Superb! I updated my theme.I think it looks amazing now :D

Could you make a pull request for the weather applet?Would be amazing if it had this too!

collinss commented 10 years ago

Yeah, I was planning on it, but hadn't had the chance. I'll do it right now though.