collinswakholi / ML_ColorCorrection_tool

Perform image color correction based on ML using the color chart (XRite ColorChecker Classic) in an image.
Other
15 stars 1 forks source link

DataColor SpyderCheckr24 Color reference colors #1

Open sergiopassalacqua opened 4 months ago

sergiopassalacqua commented 4 months ago

Hello

This library is exactly what I was looking for. I am using a DataColor SpyderCheckr24 Color reference card. I want to add a new array to support that, but I'm not 100% sure how to approach this.

This is my array definition. I am not sure if I had to, but I added the items in the array the same way they show up in the picture I attached. I also attached the results, which as you can see did not work out. What am I doing wrong? Result

    self.srgb_datacolor24 = np.array([
                            [98,187,166], # 6. Bluish green
                            [126,125,174], # 5. Blue flower
                            [82,106,60],  # 4. Foliage
                            [87,120,155], # 3. Blue sky
                            [197,145,125], # 2. Light skin
                            [112,76,60], # 1. Dark skin

                            [222,118,32], # 7. Orange                                
                            [58,88,159], # 8. Purplish blue 
                            [195,79,95], # 9. Moderate red 
                            [83,58,106], # 10. Purple
                            [157,188,54], # 11. Yellow green 
                            [238,158,25], # 12. Orange yellow

                            [0,127,159],  # 18. Cyan
                            [192,75,145], # 17. Magenta
                            [245,205,0], # 16. Yellow
                            [186,26,51], # 15. Red
                            [57,146,64], # 14. Green
                            [25,55,135],  # 13. Blue 

                            [249,242,238], # 19. White 9.5
                            [202,198,195], # 20. Neutral 8
                            [161,157,154], # 21. Neutral 6.5
                            [122,118,116], # 22. Neutral 5
                            [80,80,78], # 23. Neutral 3.5
                            [43,41,43] # 24. Black 2
                            ])       

DataColorCard

collinswakholi commented 4 months ago

Hi @sergiopassalacqua,

I used an OpenCV-based color card detection function that to my knowledge is able to read Macbeth-based Standard, DigitalSG, and Vinyl color cards only (https://docs.opencv.org/4.x/d9/d7e/tutorial_mcc_basic_chart_detection.html#Source%20Code%20of%20The%20Sample).

I could try to find a solution for this in the next release of this toolbox.