collintate / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Using locally stored images #3

Open aubreywullschleger opened 7 years ago

aubreywullschleger commented 7 years ago

Simplify! Consider using locally stored images in your project as this is best practice for production code and will make your page load faster. To do this you would create a new images folder inside your Resources folder, like this: screen shot 2017-09-19 at 6 09 54 pm

Then save your images to this new folder, and use your <img> tags like this: <img src="./Resources/images/hacksaw.jpeg" alt="Hacksaw brushes"> .

However, great work using descriptive alt attributes on your <img> elements. This is best practice and helps with accessibility as well.

Example: https://github.com/collintate/prj-rev-bwfs-dasmoto/blob/master/Dasmotos/index.html#L12

collintate commented 7 years ago

The interesting thing is I did exactly this but couldn't get the background image to load locally. When this happened, changed the URLs back to hotlinks. The background image loaded, so I left them as you saw them. I'll make sure to bring this up with Chelsea during our 1-on-1 this week.