search

collintate / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #5

Open aubreywullschleger opened 6 years ago

aubreywullschleger commented 6 years ago

Grade: Meets expectations

Summary: Awesome job on this project! I like your organized, semantic HTML, your descriptive alt attributes, and your use of the universal selector in your CSS. Keep up the great work!

A few things to work on here: 1. use the correct attribute for type on your link to the stylesheet in your HTML, 2. use locally stored images for your <img> elements and background-image, and 3. use group selectors for repeated styles in your CSS.

Next, as a stretch goal, I challenge you to research and implement media queries to make your page totally responsive for all screen widths. This is a challenge I think you are ready for based on your great work with this project! Here are a couple resources to get you started: https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries and https://css-tricks.com/snippets/css/media-queries-for-standard-devices/

collintate commented 6 years ago

Thanks for the feedback, @aubreywullschleger!

Working on this project late at night was a mistake and it shows. I made silly errors that normally woulnd't have happened if I were properly rested. I won't make that mistake again.

This leads me to a question. How do developers code into the wee hours of the morning during hackathons and not make silly errors? Are they using code checkers? Should I add-on a code checker to my Atom instance?

I apprecaite your encouragement, your positive comments and the stretch goal you challenged me to. I'll work on researching and implementing media queries to make my pages responsive for all screen widths.

Thanks again!