colmap / colmap

COLMAP - Structure-from-Motion and Multi-View Stereo
https://colmap.github.io/
Other
7.47k stars 1.5k forks source link

Windows distribution that includes CMake-based binary artifacts pretty please? python wheel support #1810

Open pwais opened 1 year ago

pwais commented 1 year ago

Dear COLMAP team,

I'm currently trying to help build windows python wheels for pycolmap:

AFAIK what pycolmap needs to build the wheel include:

I've run into the following problems though:

Today, the Windows binary GUI release ( https://github.com/colmap/colmap/releases/download/3.8/COLMAP-3.8-windows-no-cuda.zip ) does not include headers, though it appears to include the needed DLLs. I have tried to frankenstein this release with the source release ( https://github.com/pwais/pycolmap/blob/3476bfd8932e94c4d211dbec58ffe794bcdd08bf/.github/workflows/build-new.yml#L111 ) but nothing working just yet.

So, while vcpkg appears to be the preferred way to build COLMAP from source for windows, that also takes a ton of CPU time, and for pycolmap the build could actually be very fast if the right COLMAP binaries were made available.

For the linux colmap release, it's as simple as set up with cmake and then make install will help create a binary release with headers and such. Could we have the same but for Windows?

Any advice would be much appreciated. I don't develop on Windows too much so I'm still learning the area.

pwais commented 1 year ago

cc https://github.com/colmap/pycolmap/issues/111#issuecomment-1633078069 Maybe there will be a synchronized release of pycolmap and COLMAP soon