fix: arg type for std::ceil and typo in glomap::EstimateRelativePoses

colmap / glomap

GLOMAP - Global Structured-from-Motion Revisited

BSD 3-Clause "New" or "Revised" License

1.3k stars 76 forks source link

fix: arg type for std::ceil and typo in glomap::EstimateRelativePoses #94

Closed lnexenl closed 1 week ago

lnexenl commented 1 week ago

I find this bug when reconstructing 4 images. std::ceil(num_image_pairs / kNumChunks) equals to zero at here for int64(4/10) equals zero, and the relative pose estimation actually failed here.

ahojnnes commented 1 week ago

Thanks for catching this bug. LGTM.