Fix bug in UpdateFromDict

colmap / pycolmap

Python bindings for COLMAP

BSD 3-Clause "New" or "Revised" License

858 stars 125 forks source link

Fix bug in UpdateFromDict #231

Closed sarlinpe closed 5 months ago

sarlinpe commented 5 months ago

Fix the bug mentioned in https://github.com/colmap/pycolmap/pull/146:

solver_options = pycolmap.CeresSolverOptions(max_num_iterations=256)
ba_opts = pycolmap.BundleAdjustmentOptions({"solver_options": solver_options})  # error

Explicitly raise an error if a dict key is not a string
Overall cleanup