Closed sangyye closed 8 years ago
Cannot really reproduce the travis error, everything looks fine on my machine:
$ bundle exec htmlproof --check-html --disable-external ./_site
Running ["ImageCheck", "ScriptCheck", "HtmlCheck", "LinkCheck"] on ./_site on *.html...
Ran on 2 files!
HTML-Proofer finished successfully.
$ bundle exec htmlproof -v
htmlproof 2.6.4
I think it's better to attach the files and send it to you , because I have no experience On 23 Feb 2016 12:18 pm, "Christian Vervoorts" notifications@github.com wrote:
Cannot really reproduce the travis error, everything looks fine on my machine:
$ bundle exec htmlproof --check-html --disable-external ./_site Running ["ImageCheck", "ScriptCheck", "HtmlCheck", "LinkCheck"] on ./_site on *.html...
Ran on 2 files!
HTML-Proofer finished successfully. $ bundle exec htmlproof -v htmlproof 2.6.4
— Reply to this email directly or view it on GitHub https://github.com/colognerb/refugees/pull/27#issuecomment-187658509.
@khaledalhasan I think you can't add files to github comments via email.
thanks for the PR @sangyye
@khaledalhasan how about introducing arabic together at the next meeting? The next meeting will be Thursday next week (March 3rd). Will you be able to come? If yes, it would be nice if you could fill out the Doodle here http://doodle.com/poll/vspxtbxfvfxwpdtg
Yes , of course I'll be there , I filled out the doodle also . On 23 Feb 2016 2:25 pm, "Jakob Hilden" notifications@github.com wrote:
thanks for the PR @sangyye https://github.com/sangyye
@khaledalhasan https://github.com/khaledalhasan how about introducing arabic together at the next meeting? The next meeting will be Thursday next week (March 3rd). Will you be able to come? If yes, it would be nice if you could fill out the Doodle here http://doodle.com/poll/vspxtbxfvfxwpdtg
— Reply to this email directly or view it on GitHub https://github.com/colognerb/refugees/pull/27#issuecomment-187697638.
I removed the --check-html
until I know why I get the strange error in travis but not on my local machine
I have no idea why this gives an error. Everything fine on my end and on the online-validator.
@sangyye since we have no checked in Gemfile.lock, Travis might be installing different versions of our dependencies. Consider comparing the versions, and I don't think there is any reason not to check in the Gemfile.lock for this project.
@jhilden Okay, I added it, but I already checked the versions, and it seems that there are no difference in the versions.
@jhilden Even with the added Gemfile.lock it errors on travis and works fine on my local computer. Can't really understand that...
I added support for more languages than english, so it's easy to add other languages. The detection works via the default language in the browser. If this is not detected or the language is not translated, it defaults to english.
Limitations:
TODO: