search

colomemaria / epiScanpy

Episcanpy: Epigenomics Single Cell Analysis in Python
BSD 3-Clause "New" or "Revised" License
141 stars 32 forks source link

Episcanpy is incompatible with scanpy 1.4.5post3 #50

Open le-ander opened 4 years ago

le-ander commented 4 years ago

Hi Anna,

I just wanted to try out the shiny new episcanpy version. Unfortunately I found that it is incompatible with the current scanpy realease. This is because of conflicting requirements.

Episcanpy 0.1.8:

scipy<=1.3
h5py!=2.10.0

Scanpy 1.4.5.post3:

scipy>=1.3
h5py>=2.10.0

I wonder if the version pinning of episcanpy could just be adapted to the scanpy one or whether this actually requires updates to the code.

Would be great if episcanpy would soon be compatible with scanpy again :)

le-ander commented 4 years ago

I'm under the impression, that since you removed the version checks from the code, these pinnings are no longer required and episcanpy should work with the latest anndata, h5py and scipy. Or do you see any particular reasoon why that should not be the case?

If you also think that this should be fine, a new release without these version pinnings would be great, so I can create a new container with all compatible anndata 0.7, scanpy and episcanpy for our group. Thanks :)