search

colonelpanic8 / okcupyd

A Library that enables programmatic interaction with okcupid.com, using okcupid.com's private okcupid JSON API and html scraping when necessary.
MIT License
110 stars 18 forks source link

Filters #68

Open colonelpanic8 opened 9 years ago

colonelpanic8 commented 9 years ago

@dubiousjim check out my comments above.

colonelpanic8 commented 9 years ago

Seems that a syntax error in magicnumbers is causing builds to fail

dubiousjim commented 9 years ago

Found and fixed the syntax errors.

dubiousjim commented 9 years ago

Will wait a bit to see if you have any replies, then will push edits responding to the above.

dubiousjim commented 9 years ago

Have pushed commits addressing the small stuff above.

dubiousjim commented 9 years ago

I just figured out how to see the details of the build reports (duh). One of the failures is the gentation_test, that's failing because you had written the gentation filter to take a list of strings, but I changed it back to only just a string, as it was previously I think. The request object gives a list of ints to the gentation key, but I was never able to get the web browser to submit any requests where the list wasn't of length one. So, aiming for the moment to closely emulate the way the web browser makes requests and only offering an interface that accepts a single gentation value. Logically, a list of gentation values would just get bitored together on OKCupid's side anyway.

colonelpanic8 commented 9 years ago

I just figured out how to see the details of the build reports (duh). One of the failures is the gentation_test, that's failing because you had written the gentation filter to take a list of strings, but I changed it back to only just a string, as it was previously I think. The request object gives a list of ints to the gentation key, but I was never able to get the web browser to submit any requests where the list wasn't of length one. So, aiming for the moment to closely emulate the way the web browser makes requests and only offering an interface that accepts a single gentation value. Logically, a list of gentation values would just get bitored together on OKCupid's side anyway.

you can always run the tests locally using tox as well