colonelpanic8 / okcupyd

A Library that enables programmatic interaction with okcupid.com, using okcupid.com's private okcupid JSON API and html scraping when necessary.
MIT License
110 stars 18 forks source link

numerous fixes to profile.py #77

Closed kfred closed 8 years ago

kfred commented 8 years ago

fixed profile.contacted, profile.age, profile.liked, profile.match_percentage, profile.enemy_percentage

could not fix profile.location. something weird with the span; selector not recognized despite its similarity to profile.age.

colonelpanic8 commented 8 years ago

Cool this looks pretty good, but I imagine it broke a bunch of tests. Did you take a look at that. It looks like something changed with travis that is making the build always fail, but you should be able to run them locally.

kfred commented 8 years ago

Cool, I haven't yet dug into the travis details. I got a bit keyboard happy and started half fixing/half testing, anything that would support my downstream script ideas, so there's likely some messiness in there breaking things. I'll revisit this weekend, and try to track down the root of those test failures.

I've been rebuilding and running locally without issue, but I only have so far used profile, question and message features.

After I sort out these failed tests and update the profile features, I'm happy to take a stab at updating essay features. With profile and essay up and running (in addition to working question and messaging), this library should be fairly functional again (even with the currently somewhat limited search features).

kfred commented 8 years ago

Apologies on the multiple pull requests... It's my git n00b-ness shining through.

I wanted to reset my fork, then reapply my commits to test against travis (which explains the second pull request), but then realized those are the same checks performed in tox, so I then further proceeded using the local tox tests and tox venv interactive mode to confirm my commits before (finally) pushing a new set of commits to my current fork.

The (third) current pull request reflects those latest updates, along with some additional info on my discoveries and implementation.