search

colonial-heritage / research-guides-dev

Development repo for integrating the research guides from NIOD into the Datahub
Creative Commons Attribution Share Alike 4.0 International
0 stars 0 forks source link

mixed types for numbers #1

Closed valevo closed 4 months ago

valevo commented 4 months ago

issue

here the year is given as an integer type: https://github.com/colonial-heritage/research-guides-dev/blob/ad7389401dd5eee65d5c9a3b9500aec987f7abee/niveau3/version2/NZG_v02_20240314.yml#L23

but here it is given as a string type: https://github.com/colonial-heritage/research-guides-dev/blob/ad7389401dd5eee65d5c9a3b9500aec987f7abee/niveau3/version2/KKZ_v02_20240313.yml#L28

explanation

the difference is the quotation marks (") around the year. quotation marks are optional for string types (i.e. anything textual) but the presence of quotation marks always indicates a string type. so "hello" and hello have the same type (namely string) but 1964 and "1964" do NOT have the same type (the first is of type integer and the second of type string)

instructions

please be consistent in the types you use for instance of the same data. specifically, for dates that consist only of years it isn't that important if you use integer type or string type, as long as it's consistent.

note: a full date in the representation 1986-02-23 cannot be an integer and will always be a string (like the word hello), because it isn't a number_ (the character - cannot appear in numbers)

wreints commented 4 months ago

I updated the years so that all of them are in quotation marks. As far as I could see, this was only needed in the NZG one.