search

colonial-heritage / research-guides-dev

Development repo for integrating the research guides from NIOD into the Datahub
Creative Commons Attribution Share Alike 4.0 International
0 stars 0 forks source link

type is list, needs to be dict #31

Closed valevo closed 2 months ago

valevo commented 2 months ago

seems like this issue is in all level 3 RGs (and possibly in level 2 as well) but e.g. in https://github.com/colonial-heritage/research-guides-dev/blob/43d08d3785bdbdf401a79c3459735e09343652da/niveau3/Dutch/NZG_20240314.yml#L43

in field "Main-text" contains a list, not a dictionary (with keys "content" and "content-type")

so

"Main-text":
   - content: |
            some text
  - content-type: "ext/markdown"

needs to be

"Main-text":
     content: |
            some text
     content-type: "ext/markdown"
valevo commented 2 months ago

please fix asap, blocks front-end work

wreints commented 2 months ago

Done for level 2 now. But for the future (next week), if there are such small changes that are very important for the front-end, which do not change anything to the content of the RA, please make the needed changes yourself if you see them. Same goes for typos or other listing problems. I'll try to fix the Level3's asap

valevo commented 2 months ago

thanks for suggesting that but we have a fairly strict policy (for good reasons) to not mess with source data

wreints commented 2 months ago

OK, that makes sense. Done for Level 3 now as well.