search

colopl / laravel-spanner

Laravel database driver for Google Cloud Spanner
Apache License 2.0
97 stars 16 forks source link

fix: prepareBinding should not have changed return type #188

Closed taka-oyama closed 9 months ago

taka-oyama commented 9 months ago

Reverts part that changed the return type in https://github.com/colopl/laravel-spanner/pull/168.

Broke toRawSql formatting output for DateTime objects.

taka-oyama commented 9 months ago

If this is applied, ARRAY<TIMESTAMP> will break so there's not clear answer to this. We'll just have to live with this.

taka-oyama commented 9 months ago

CHANGELOG has been updated to address this.

https://github.com/colopl/laravel-spanner/blob/29a10c9e0aa0d168272eacd7f322a90c83372837/CHANGELOG.md?plain=1#L17