Closed taka-oyama closed 2 weeks ago
This pull request introduces various formatting changes across multiple files, primarily focusing on improving code readability and consistency. Changes include adjustments to spacing around operators, method signatures, and PHPDoc annotations, as well as the addition of trailing commas in method calls. Overall, the modifications are cosmetic and do not affect the logic or functionality of the code.
File | Change Summary |
---|---|
src/Concerns/ManagesDataDefinitions.php | Minor formatting change in waitForOperation method, adjusted spacing around json_encode . |
src/Concerns/ManagesMutations.php | Formatting change in createDeleteMutationKeySet method, improved spacing in exception message. |
src/Concerns/ManagesSessionPool.php | Formatting change in warmupSessionPool method, added space after if keyword. |
src/Concerns/ManagesTransactions.php | Formatting changes in PHPDoc comments and method calls, added trailing commas in method calls. |
src/Concerns/MarksAsNotSupported.php | Formatting adjustment in markAsNotSupported method's exception message concatenation. |
src/Concerns/SharedGrammarCalls.php | Formatting change in wrapValue method's return statement, adjusted string concatenation. |
src/Connection.php | Return type changes for table and query methods, formatting adjustments in executeBatchDml . |
src/Console/SessionsCommand.php | Formatting changes in makeSessionData method, improved spacing in anonymous functions. |
src/Eloquent/Model.php | Parameter annotations reformatted in resolveChildRouteBindingQuery method. |
src/Query/ArrayValue.php | Added trailing comma in constructor parameter list. |
src/Query/Builder.php | Minor formatting changes in updateOrInsert , upsert , and runSelect methods. |
src/Query/Concerns/UsesPartitionedDml.php | Added trailing commas in method calls for prepareBindingsForUpdate and prepareBindingsForDelete . |
src/Query/Grammar.php | Formatting changes in method return statements and error handling messages. |
src/Query/Parameterizer.php | Changed else if to elseif for consistency in conditional statements. |
src/Query/Processor.php | Changed else if to elseif in processSelect method. |
src/Schema/Blueprint.php | Adjusted parameter annotations for consistency and added trailing commas in method calls. |
src/Schema/Builder.php | Formatting improvements in getTables , dropIndexIfExist , and dropAllTables methods. |
src/Schema/Grammar.php | Adjusted PHPDoc comments and added commas in method calls for consistency. |
tests/Concerns/ManagesDataDefinitionsTest.php | Formatting changes in lambda function definitions for consistency. |
tests/ConnectionTest.php | Formatting improvements in closures and SQL statements. |
tests/Eloquent/ModelTest.php | Adjusted spacing around concatenation operators in multiple methods. |
tests/Query/BuilderTest.php | Minor whitespace changes and assertion adjustments in various test methods. |
tests/Query/ParameterizerTest.php | Reformatted $bindings variable for improved readability. |
tests/Query/SpannerArrayTest.php | Added spaces around + operator in testSearchInArray method. |
tests/Schema/BlueprintTest.php | Updated SQL assertions for correct formatting in multiple test methods. |
tests/Schema/BuilderTestLast.php | Standardized spacing in arrow function declarations and comments. |
tests/SpannerServiceProviderTest.php | Removed space between fn and parentheses in test_change_cache_path method. |
tests/TestCase.php | Various formatting adjustments for consistency in TestCase class. |
tests/TransactionTest.php | Standardized formatting in use statements and exception handling syntax. |
tests/bootstrap.php | Minor formatting adjustments in autoload requirement and shutdown function. |
waitForOperation
method in the ManagesDataDefinitions
trait, while the retrieved PR adds change stream support in the Blueprint
class, indicating a potential relationship in handling data definitions and operations.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Release Notes
Bug Fixes
executeBatchDml
method to provide more detailed error messages.escape
method to enforce stricter input rules.New Features
table
andquery
methods for better type safety.Style
Tests